-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immediately show file size message for large attachments #42739
Conversation
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hi @ShridharGoel can you also share recordings (native apps only) to test the bug here #40492? |
Screen.Recording.2024-05-29.at.6.51.13.PM.online-video-cutter.com.mp4 |
@hoangzinh Can you help in checking for Android? I'm having some issue with the build. |
I can reproduce neither on Android Screen.Recording.2024-05-31.at.17.26.27.android.mov |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-05-31.at.17.26.27.android.movAndroid: mWeb ChromeScreen.Recording.2024-05-31.at.18.02.17.android.chrome.moviOS: NativeScreen.Recording.2024-05-31.at.18.08.31.ios.moviOS: mWeb SafariScreen.Recording.2024-05-31.at.18.06.30.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2024-05-31.at.17.33.26.web.movMacOS: DesktopScreen.Recording.2024-05-31.at.17.53.48.desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tylerkaraszewski Can you have a look when possible? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This PR is failing because of issue #38478 The issue is reproducible in: Android app 1718053185964.screen-20240610-165908.mp4 |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
Details
Immediately show file size message for large attachments.
Fixed Issues
$ #38478
PROPOSAL: #38478 (comment)
Tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-03-31.at.1.37.40.PM.mov
Android: mWeb Chrome
video_20240406_001529_edit.mp4
iOS: Native
Screen.Recording.2024-03-31.at.1.05.05.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-04-04.at.11.40.52.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-04.at.11.38.07.PM.mov
MacOS: Desktop
Screen.Recording.2024-04-04.at.11.46.55.PM.mov